🎯 Support --execute for building non-sites
#1416
Conversation
🦋 Changeset detectedLatest commit: be48d66 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Oh nooo, I made basically this identical change at scipy, but it got lost in the shuffle 😅 - sorry! Thanks for getting it over the line. The diffs are almost exactly the same, which builds some confidence... f96a862
Also - regarding Session clones: This is required since sessions have a single store with a single mdast entry for each file. Each export runs its own transformations which mutate the mdast in place, so when running exports in parallel, they must each have their own session or these mutations will conflict. As far as I know, your Jupyter session can (and should) be shared across these, no problem.
|
Haha, that's sprints for you I suppose! Thanks for taking a look at this, I feel reassured that we settled on the same solutions. Merging :) |
Fixes #1415
@fwkoch I'm not clear on what the purpose of
session.cloneis, so I'm not sure whether sharing a Jupyter session between all clones is reasonable. I think we want the Jupyter session manager to be a singleton so that we don't end up spinning up multiple local servers, but your input is useful here if I've got the wrong end of the stick.