Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐍 Don't resolve node symlink #1420

Merged
merged 2 commits into from
Jul 31, 2024
Merged

🐍 Don't resolve node symlink #1420

merged 2 commits into from
Jul 31, 2024

Conversation

agoose77
Copy link
Contributor

@agoose77 agoose77 commented Jul 31, 2024

There's no need for us to resolve this symlink, and some platforms like Snap use a single binary to dispatch aliased applications (i.e. symlink with name node points to /usr/bin/snap).

This PR changes the Path.resolve() to Path.absolute(), and fixes a mistake in the node version validation.

Fixes #1419

Copy link

changeset-bot bot commented Jul 31, 2024

⚠️ No Changeset found

Latest commit: c5f4245

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@agoose77 agoose77 merged commit a753238 into main Jul 31, 2024
7 checks passed
@agoose77 agoose77 deleted the agoose77/fix-mystmd-resolve branch July 31, 2024 09:00
@rowanc1 rowanc1 requested a review from fwkoch July 31, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Myst fails to start with Snap node installation
1 participant