␡ Enable strikethrough as markdownit extension #1427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ends up parsing out to a `delete` node and uses the rendering logic for the delete directive
🦋 Changeset detectedLatest commit: fcbcd94 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Thanks for adding those tasty-fireants! Is this one good to go? |
|
Hi @rowanc1 is this ready to merge? |
rowanc1
changed the title
|
Added a test - thanks for the nudge. Will get this in when it goes green! |
rowanc1
reviewed
Aug 21, 2024
| @@ -75,6 +76,7 @@ export function createTokenizer(opts?: Options) { | |||
| if (markdownit.linkify) { | |||
| tokenizer.linkify.tlds(tlds.filter((tld) => !EXCLUDE_TLDS.includes(tld))); | |||
| } | |||
| if (extensions.strikethrough) tokenizer.enable('strikethrough'); | |||
There was a problem hiding this comment.
Note: This is not enabled by default and I am not sure if there is a way to turn this on from the CLI quite yet. We can add those features in future!
|
Thanks @sglyon for your help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ends up parsing out to a
deletenode and uses the rendering logic for the delete directive