Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🖼 Add icon node #1432

Merged
merged 6 commits into from
Aug 29, 2024
Merged

🖼 Add icon node #1432

merged 6 commits into from
Aug 29, 2024

Conversation

agoose77
Copy link
Contributor

@agoose77 agoose77 commented Aug 9, 2024

This PR adds support for a subset of the icon syntax from sphinx-design. Although this new role supports the legacy role names such as {fab}, the preferred aliases are:

'icon:oct',
'icon:mrg',
'icon:mol',
'icon:mrd',
'icon:msp',
'icon:mtt',
'icon:fab',
'icon:far',
'icon:fas'

Copy link

changeset-bot bot commented Aug 9, 2024

🦋 Changeset detected

Latest commit: 58ef048

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
myst-ext-icon Minor
myst-cli Patch
mystmd Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@rowanc1 rowanc1 changed the title 🖼️ Add icon node 🖼 Add icon node Aug 9, 2024
@agoose77 agoose77 force-pushed the agoose77/feat-sphinx-ext-design branch from 6171da0 to ba32e5e Compare August 28, 2024 14:21
@agoose77 agoose77 marked this pull request as ready for review August 28, 2024 14:42
@agoose77
Copy link
Contributor Author

@rowanc1 should we look to merging this ahead of getting theme support? Do you concur that it's worth targeting the same icon packs as sphinx-design?

@rowanc1
Copy link
Collaborator

rowanc1 commented Aug 28, 2024

Let's talk about the icon packs we support when we build out the theme (probably lower priority than some of the other things we have on at the moment).

@agoose77 agoose77 merged commit 9c28805 into main Aug 29, 2024
7 checks passed
@agoose77 agoose77 deleted the agoose77/feat-sphinx-ext-design branch August 29, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants