Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🖊️ Fix filename and highlight typo in contribute-add-feature.md #1465

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

ValMystletainn
Copy link
Contributor

Change

the code block filename and emphasize-lines in docs/contribute-add-feature.md,
turns some packages/myst-transforms/src/index.ts into packages/myst-cli/src/process/mdast.ts to keep the consistency with the context above and practice.

The previous version just mislead me at my first time to go through the guide

Copy link

changeset-bot bot commented Aug 17, 2024

⚠️ No Changeset found

Latest commit: f204371

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@agoose77 agoose77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great catch! Thanks :)

@agoose77 agoose77 changed the title fix: filename and highlight typo in the contribute-add-feature.md 🖊️ Fix filename and highlight typo in contribute-add-feature.md Aug 19, 2024
@agoose77 agoose77 merged commit c37f8d2 into jupyter-book:main Aug 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants