🔢 Add enumeration options to common directives #1477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a165d36 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
agoose77
reviewed
Aug 22, 2024
agoose77
reviewed
Aug 22, 2024
Co-authored-by: Angus Hollands <[email protected]>
|
Yes - I purposely left |
Co-authored-by: Angus Hollands <[email protected]>
fwkoch
approved these changes
Aug 22, 2024
| }, | ||
| ...labelDirectiveOption('blockquote'), | ||
|
|
||
| // TODO: Add enumeration in future |
There was a problem hiding this comment.
Good that we are not adding enumerator on places where we do not number stuff yet.
There was a problem hiding this comment.
Looking forward to being able to number everything ... !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
enumerated/enumerator(aliased asnumbered/number) to all common directives (code, figures, etc.). This allows for things like turning off enumeration for a specific figure / equation as well as taking control of numbering completely.In a recent example, we had to create a figure with a specific number
S5and then carry on numbering as usual.This also introduces some places to centralize directive option logic - which we could extend to classes in the future.