Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🗃 Start admonitions in the open position #1486

Merged
merged 3 commits into from
Aug 22, 2024
Merged

🗃 Start admonitions in the open position #1486

merged 3 commits into from
Aug 22, 2024

Conversation

rowanc1
Copy link
Collaborator

@rowanc1 rowanc1 commented Aug 22, 2024

Copy link

changeset-bot bot commented Aug 22, 2024

🦋 Changeset detected

Latest commit: cad9771

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
myst-directives Patch
myst-spec-ext Patch
myst-common Patch
myst-config Patch
myst-frontmatter Patch
myst-parser Patch
myst-roles Patch
myst-to-html Patch
myst-transforms Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

docs/admonitions.md Outdated Show resolved Hide resolved
@rowanc1

This comment was marked as outdated.

Copy link
Collaborator

@fwkoch fwkoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good - not changing the default but adding a simple open option.

Rather than introducing validation errors if dropdown and open disagree, could we just have open: true/false imply class: dropdown?

@rowanc1
Copy link
Collaborator Author

rowanc1 commented Aug 22, 2024

We took @fwkoch's suggestion of coercing and working either way!

@rowanc1 rowanc1 merged commit 4e880f3 into main Aug 22, 2024
7 checks passed
@rowanc1 rowanc1 deleted the feat/admonition branch August 22, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allow dropdown admonitions to start open
3 participants