-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
π©βπ¬ Add more frontmatter fields for different venue types #1503
Conversation
π¦ Changeset detectedLatest commit: ee89a71 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
As usual, when writing this up, I realize I need to add the comment I made in this PR to the docs π |
Docs are now updated! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there are some naming / location updates for the frontmatter that could be done. Especially around the issue/volume side? Maybe volume/issue should be objects each with their own metadata in biblio?
Maybe this is just prefixing issue_
to things in biblio?
docs/frontmatter.md
Outdated
* - `doi` | ||
- the _issue_ DOI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think make changing this to issue_doi
might be better. Unlike the venue, this isn't totally clear that the biblio.doi
is for the issue?
docs/frontmatter.md
Outdated
* - `title` | ||
- title of the journal issue in the case where there is both volume/issue number and separate title | ||
* - `subject` | ||
- description of the subject of the journal issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to doi, the title/subject here could maybe just be expanded to issue_subject
and issue_title
?
Yeah - that makes sense. We adopted This would allow us to grow, even beyond this current PR. For example So, something like:
becomes:
|
I like that approach @fwkoch. It would be nice to support |
21b8611
to
87cf7d7
Compare
I have updated this PR to deprecate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments in a live review.
68785ae
to
523f477
Compare
Awesome - looks good! |
This just adds a few fields to
frontmatter.venue
andfrontmatter.biblio
.biblio
contains volume/issue info - these may now have atitle
andsubject
venue
is a bit more flexible - it may be a journal, a conference, an entry in a conference proceedings series, etc...location
,date
,number
may apply to a conference;issn
andpublisher
may apply to a journal;series
may apply to a series of publications (JATS has a similar field: https://jats.nlm.nih.gov/archiving/tag-library/1.3/element/series.html)