Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👷 Check platform.system to fix myst on Windows #1510

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

agoose77
Copy link
Contributor

@agoose77 agoose77 commented Sep 2, 2024

We use os.exec to make the MyST binary an invisible wrapper after startup. However, on Windows this doesn't work as intended. So, this PR sets up a subprocess on Windows instead.

Fixes #1425

Copy link

changeset-bot bot commented Sep 2, 2024

⚠️ No Changeset found

Latest commit: be46b44

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@rowanc1
Copy link
Collaborator

rowanc1 commented Sep 2, 2024

Nice! Have you tested this on Windows?

@agoose77
Copy link
Contributor Author

agoose77 commented Sep 2, 2024

Yep! It works :)

@rowanc1 rowanc1 merged commit 15997fd into main Sep 2, 2024
7 checks passed
@rowanc1 rowanc1 deleted the agoose77/fix-windows branch September 2, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keyboard input hangs on windows
2 participants