🔍 Add client-side search index generation #1530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e97f56b The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Making a change to expose a version. |
agoose77
commented
Sep 12, 2024
| parts: string[]; | ||
| }; | ||
|
|
||
| export function toSectionedParts(content: GenericNode) { |
There was a problem hiding this comment.
This naively sections a document upon encountering a heading. Seems to work well so far.
rowanc1
reviewed
Sep 13, 2024
5 tasks
agoose77
force-pushed
the
agoose77/feat-add-search
branch
from
b340152
to
01e3008
Compare
rowanc1
reviewed
Sep 13, 2024
|
Just working on improving the AST to text transform. |
agoose77
force-pushed
the
agoose77/feat-add-search
branch
from
790c407
to
f8260b2
Compare
|
We should support 1 apparently. Ideally the CLI should not crash if search index cannot be made!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tackles #100 by adding support for generation of
myst.search.jsonindices. These can currently be consumed by a webapp onhttps://agoose77.github.io/myst-search-experiments/?url=http://..., which tries to usemyst.search.json, and falls back on using the xref data.We need jupyter-book/myst-theme#467 to be merged for this to actually be deployed to static builds.
Warning
This PR should merge alongside the other search-related PRs; it is likely that changes in the frontend may warrant modifications to this PR.