📒 Track notebook source for embedded content #334
Conversation
| @@ -179,7 +179,7 @@ export async function writeFile( | |||
| const toc = tic(); | |||
| const selectedFile = selectFile(session, file); | |||
| if (!selectedFile) return; | |||
| const { frontmatter, ...mdastPost } = selectedFile; | |||
| const { frontmatter, mdast, kind, sha256, slug, references, dependencies } = selectedFile; | |||
There was a problem hiding this comment.
This is just removing file from the written page config. I think this is ok? Previously this was writing local file paths... not useful at all for the site. (The original file is still available as a download in the export lists.)
There was a problem hiding this comment.
My thought on file is that it will be helpful when we sync up with an 'Edit on GitHub' which will require a local file path.
There was a problem hiding this comment.
ok so sounds like this is one mini change to revert!
There was a problem hiding this comment.
In talking through with @fwkoch I think we should actually remove file, it is non-relative at the moment. We can bring this back soon with a feature of edit on github!
|
Code changes look good. I think I would prefer to keep Another note: |
figure/embeddirectives may embed code/output cells from other notebooks. To recompute these, we need to know where they come from.This PR adds url
sourceandsourceKeyto all embed nodes to locate the source notebook cell. This also addsdependenciesat the top level of the page config with all url sources required to compute embedded content in the page.