Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds collaboration associated with author #343

Merged
merged 3 commits into from
May 31, 2023

Conversation

dressedfez
Copy link
Contributor

This PR would enable us to add a collaboration field as need by the Physical Review Template.

The template has been updated accordingly see here.

@welcome
Copy link

welcome bot commented Apr 2, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

@rowanc1
Copy link
Collaborator

rowanc1 commented Apr 10, 2023

Hey @dressedfez - thanks for the PR, sorry it has taken a bit to get back to you.

This looks good in principle, and I think there is good precedence for supporting it, for example in JATS:
https://jats.nlm.nih.gov/archiving/tag-library/1.3/element/collab.html

image

I would love to get @fwkoch's thoughts on adding this at the base level, and how this might work into plans to improve the affiliation work?

@rowanc1 rowanc1 requested a review from fwkoch April 10, 2023 16:59
@dressedfez
Copy link
Contributor Author

@rowanc1 @fwkoch any idea here if you guys want to proceed with it?

@rowanc1
Copy link
Collaborator

rowanc1 commented May 31, 2023

Hi @dressedfez, sorry for the delay, we were working up to JupyterCon and then many of us were on vacation. Looking at this now!

@rowanc1 rowanc1 merged commit 97518ca into jupyter-book:main May 31, 2023
@welcome
Copy link

welcome bot commented May 31, 2023

Congrats on your first merged pull request in this project! 🎉
congrats

Thank you for contributing, we are very proud of you! ❤️

@rowanc1
Copy link
Collaborator

rowanc1 commented May 31, 2023

Thanks @dressedfez for your help (and patience) with getting this in!! We will release this some time this week or early next week probably!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants