🔀 Consolidate id deduplication/simplification for JATS #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st-to-jats transforms
* 🧹 Remove empty output nodes when reducing outputs for pdf/docx * 🧹 Combine caption+legends into multi-paragraph captions for tex export
|
Yay!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JATS requires no duplicate ids across all identifiers (sections, citations, footnotes, etc etc). Further, most examples of JATS files have simple identifiers like
ref-1,sec-5etc.To solve the first problem, I previously scattered suffixes, hashes, etc throughout the
myst-cliandmyst-to-jatscodebase... it was messy code, made messy ids, and didn't solve all the problems (duplicate ids still popped up in realistic examples).This PR eliminates the mess described in the previous paragraph and brings all deduplication/simplification to a couple transforms isolated to
myst-to-jats: (1) first, a transform that replaces all the identifiers on the targets and creates a lookup of the replacements, then (2) a transform that updates all the references based on the lookup.