🤐 Use adm-zip to unzip templates, not unzipper #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fwkoch can you confirm this also fixes the site clone, I am not seeing the code for that. |
fwkoch
force-pushed
the
fix/template-unzip
branch
from
6e96a07
to
9653dc9
Compare
|
Oops! You're right, added it now. |
|
This has broken site templates, they are not unzipped correctly and are nested into a folder. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should address myst-templates/docx_default#1
Same change we made here: curvenote/jats#19
Also this switches site template download from
git cloneto admzip. Before we needed a clone in order to pick up submodules. Now, though, the templates are bundled nicely and can simply be downloaded. Hopefully fixes: #209Note - it would be good to update the myst-templates API to have zip urls for site templates, not git, but for now, we construct zip from git.