Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📦 📖 Installing mystmd from conda, pypi, and npm #732

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

rowanc1
Copy link
Collaborator

@rowanc1 rowanc1 commented Nov 7, 2023

See #139

@rowanc1 rowanc1 requested a review from fwkoch November 7, 2023 05:46
Copy link
Collaborator

@fwkoch fwkoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really nice - iterative update to the docs - improving some styling, removing some out-of-date content.

:class: dropdown

You should have these programs installed:

- [Node.js](https://nodejs.org) version **>=16.0.0**
- [Node.js](https://nodejs.org) version **>=18.0.0**
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is minor inconsistency with >=18 vs 16/18/20 elsewhere. We could just change it to 18/20 everywhere, gently encouraging upgrades.

@fwkoch fwkoch merged commit ed25984 into main Nov 9, 2023
4 checks passed
@fwkoch fwkoch deleted the feat/installing branch November 9, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants