⚙️ Allow min/max/number on template types #774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rowanc1
commented
Nov 22, 2023
fwkoch
approved these changes
Nov 23, 2023
There was a problem hiding this comment.
Ah, so these are already supported on the actual option validation side - https://github.com/executablebooks/mystmd/blob/main/packages/myst-templates/src/validators.ts#L83 - they just were never added to the template option validation. 🤔
Looks good - there are a few more simple tests we could add if we want coverage of all the error cases introduced here... but those aren't a huge deal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the min/max/integer options to the template defs, for example in #773 we need an integer number with bounds.