Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎆 No subfigures option #778

Merged
merged 2 commits into from
Nov 24, 2023
Merged

🎆 No subfigures option #778

merged 2 commits into from
Nov 24, 2023

Conversation

fwkoch
Copy link
Collaborator

@fwkoch fwkoch commented Nov 24, 2023

Recent release of subfigures caused some funny behaviour with notebook cell figures: the code became the "figure" and output was unexpectedly added to the "caption"

To fix that, this adds output as a figure-content type. However, that change turns notebook cell figures into subfigures (a) code and (b) output. Now there is an additional no-subfigures option - It can be used explicitly on figure directives to suppress subfigure behaviour, and it comes in implicitly on notebook cell figures to keep them a single figure with both code and output.

@rowanc1
Copy link
Collaborator

rowanc1 commented Nov 24, 2023

Works great! Thank you!

@rowanc1 rowanc1 merged commit 2403f37 into main Nov 24, 2023
4 checks passed
@rowanc1 rowanc1 deleted the feat/no-subfigs branch November 24, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants