Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Duplicate bibtex entries when uppercase #842

Merged
merged 1 commit into from
Jan 11, 2024
Merged

🐛 Duplicate bibtex entries when uppercase #842

merged 1 commit into from
Jan 11, 2024

Conversation

rowanc1
Copy link
Collaborator

@rowanc1 rowanc1 commented Jan 11, 2024

There was a bug when @ARTICLE was used, it seems to work in both tex and typst, but we would render all citations when encountering it.

fwkoch
fwkoch approved these changes Jan 11, 2024
View reviewed changes
Copy link
Collaborator

@fwkoch fwkoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the fallback to rendering all entries is pretty extreme. This makes sense.

@rowanc1 rowanc1 merged commit 860c297 into main Jan 11, 2024
4 checks passed
@rowanc1 rowanc1 deleted the bug/bibtex branch January 11, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fwkoch fwkoch fwkoch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rowanc1 @fwkoch