Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹fix lint errors #884

Closed
wants to merge 2 commits into from
Closed

🧹fix lint errors #884

wants to merge 2 commits into from

Conversation

stevejpurves
Copy link
Contributor

@stevejpurves stevejpurves commented Feb 2, 2024

Fixing some minor lint issues, that are breaking downstream ci:lint (prettier) steps

? count?.length
: Object.keys(count ?? {}).length) ?? 0;
? count?.length
: Object.keys(count ?? {}).length) ?? 0;
return f
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change looks sensible to fix the linter, local npm run lint is happy, yet ci still fails -- @fwkoch @agoose77 has anything changed around our prettier config recently?

@stevejpurves
Copy link
Contributor Author

downstream monorepos should update prettier manually to get over this (see #864)

@rowanc1 rowanc1 deleted the fix/lint branch February 9, 2024 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant