Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Contribute template docs #970

Merged
merged 2 commits into from
Mar 11, 2024
Merged

📖 Contribute template docs #970

merged 2 commits into from
Mar 11, 2024

Conversation

rowanc1
Copy link
Collaborator

@rowanc1 rowanc1 commented Mar 11, 2024

@choldgraf following your lead this is some pointers to more tempalte docs and tutorials.

Copy link
Collaborator

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, I think it could be merged as-is, but if you have a moment it would be helpful to include a short explanation of what jtex is somewhere, since the links are taking people to the jtex documentation and it might be confusing to them to suddenly be in a new docs space. Either way it LGTM

@rowanc1
Copy link
Collaborator Author

rowanc1 commented Mar 11, 2024

Roger that. I think we want to probably be calling this "templates" now or something less tied to latex. The tex part of jtex is confusing now that we are using the same libraries to render latex and typst using jinja.

Will update the text and merge!

@rowanc1
Copy link
Collaborator Author

rowanc1 commented Mar 11, 2024

I went with removing the explicit reference to the (now outdated) library name and just explained that the current docs are aimed at latex templates. These will need to be improved as we add increasing support for typst etc.

@rowanc1 rowanc1 merged commit 4c7c728 into main Mar 11, 2024
4 checks passed
@rowanc1 rowanc1 deleted the docs/templates branch March 11, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants