Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧮 Fix AMSMath environment for LaTeX #977

Merged
merged 4 commits into from
Mar 15, 2024
Merged

Conversation

LecrisUT
Copy link
Contributor

Closes #974

Copy link

welcome bot commented Mar 13, 2024

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

@LecrisUT
Copy link
Contributor Author

Ok, this for now handles the issue according to #974 (comment) approach.

@LecrisUT LecrisUT marked this pull request as ready for review March 13, 2024 15:38
@rowanc1
Copy link
Collaborator

rowanc1 commented Mar 13, 2024

@LecrisUT thanks for the PR - I added a few test cases (feel free to add some more) and extended to other ams environments that should not be wrapped in equation environments.

I think this is an incremental improvement, however, we are not yet handling labels correctly (I don't think).

I removed the throw from your code, we can add an error to the tree/console there if we want to highlight it, but I think following up with another PR might be best.

Let me know if you are happy with the changes and we can get it in and released.

packages/myst-to-tex/src/math.ts Outdated Show resolved Hide resolved
packages/myst-to-tex/src/math.ts Show resolved Hide resolved
@rowanc1 rowanc1 changed the title fix: AMSMath environment 🧮 Fix AMSMath environment for LaTeX Mar 15, 2024
@rowanc1 rowanc1 merged commit 1b3c9e2 into jupyter-book:main Mar 15, 2024
4 checks passed
Copy link

welcome bot commented Mar 15, 2024

Congrats on your first merged pull request in this project! 🎉
congrats

Thank you for contributing, we are very proud of you! ❤️

@rowanc1
Copy link
Collaborator

rowanc1 commented Mar 15, 2024

Thanks again @LecrisUT for all your help in recent days! Excited to get this released soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MD -> LaTeX: gather is not properly generated
2 participants