Fix the bug that reconnectsparkmagic cause 'Error Starting Kernel' in jupyterlab #690
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the bug that reconnectsparkmagic cause 'Error Starting Kernel' in jupyterlab, add the parameter 'name' in create new session.
The function self._get_kernel_manager_new_session create a new session without passing the 'name' parameter, it creates a session with its name is null, the response for api '/api/sessions' in jupyter notebook contains an item with the name is null, this cause the jupyterlab failed to load the session list. When we refresh the jupyterlab web page, jupyterlab pop a 'Error Starting Kernel' error.
Test in jupyterlab 2.1.3, this pop the error 'Error Starting Kernel'. In jupyterlab 2.2.9, it doesn't pop this error, but failed to load the running sessions in 'Running Terminals and Kernels' subpage.
Checklist
CHANGELOG.md
fileREADME.md
file