Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All robot CI tests are failing, possibly due to a string in notebook version specs #444

Closed
krassowski opened this issue Dec 31, 2020 · 3 comments · Fixed by #445
Closed
Assignees

Comments

@krassowski
Copy link
Member

Description

Observed on #433. All systems, all Python versions, all robot tests.

=============================================================================
Windows36.00 Smoke                                                            
==============================================================================
Lab Version                                                           | FAIL |
Parent suite setup failed:
Evaluating expression '__import__("json").loads("""
    {"appName": "JupyterLab", "appNamespace": "jupyterlab", "appSettingsDir": "C:/Miniconda/envs/jupyterlab-lsp/share/jupyter/lab/settings", "appUrl": "/lab", "appVersion": "2.2.9", "baseUrl": "/@est/", "buildAvailable": false, "buildCheck": false, "cacheFiles": true, "devMode": false, "exposeAppInBrowser": false, "fullAppUrl": "/@est/lab", "fullListingsUrl": "/@est/lab/api/listings", "fullMathjaxUrl": "/@est/static/components/MathJax/MathJax.js", "fullSettingsUrl": "/@est/lab/api/settings", "fullStaticUrl": "/@est/static/lab", "fullThemesUrl": "/@est/lab/api/themes", "fullTreeUrl": "/@est/lab/tree", "fullWorkspacesApiUrl": "/@est/lab/api/workspaces", "fullWorkspacesUrl": "/@est/lab/workspaces", "ignorePlugins": [], "listingsUrl": "/lab/api/listings", "mathjaxConfig": "TeX-AMS-MML_HTMLorMML-full,Safe", "notebookVersion": "[6, 1, 6, \"\"]", "quitButton": true, "rootUri": "file:///d:/a/jupyterlab-lsp/jupyterlab-lsp/atest/output/windows_36_1/home/n%C3%B6te%20b%C3%B2%C3%B3ks", "schemasDir": "C:/Miniconda/envs/jupyterlab-lsp/share/jupyter/lab/schemas", "serverRoot": "~/n\u00f6te b\u00f2\u00f3ks", "settingsUrl": "/lab/api/settings", "staticDir": "C:/Miniconda/envs/jupyterlab-lsp/share/jupyter/lab/static", "staticUrl": "/static/lab", "store_id": 0, "templatesDir": "C:/Miniconda/envs/jupyterlab-lsp/share/jupyter/lab/static", "terminalsAvailable": true, "themesDir": "C:/Miniconda/envs/jupyterlab-lsp/share/jupyter/lab/themes", "themesUrl": "/lab/api/themes", "token": "ZxaumStD", "treeUrl": "/lab/tree", "userSettingsDir": "D:/a/jupyterlab-lsp/jupyterlab-lsp/atest/output/windows_36_1/user-settings", "virtualDocumentsUri": "file:///d:/a/jupyterlab-lsp/jupyterlab-lsp/atest/output/windows_36_1/home/n%C3%B6te%20b%C3%B2%C3%B3ks/.virtual_documents", "workspacesApiUrl": "/lab/api/workspaces", "workspacesDir": "D:/a/jupyterlab-lsp/jupyterlab-lsp/atest/output/windows_36_1/workspaces", "workspacesUrl": "/lab/workspaces", "wsUrl": ""}
  """)' failed: JSONDecodeError: Expecting ',' delimiter: line 2 column 846 (char 846)
------------------------------------------------------------------------------
Root URI :: the rootUri should be set in the page config              | FAIL |

The 846 region is:

   "notebookVersion": "[6, 1, 6, \"\"]"

which is indeed strange version for a notebook version. On an older installation this was normal, e.g.: "notebookVersion": "[6, 0, 3]".

The relevant code is:

Read Page Config
    ${script} =    Get Element Attribute    id:jupyter-config-data    innerHTML
    ${config} =    Evaluate    __import__("json").loads("""${script}""")
    Set Global Variable    ${PAGE CONFIG}    ${config}
    Set Global Variable    ${LAB VERSION}    ${config["appVersion"]}
krassowski referenced this issue in jupyter/notebook Dec 31, 2020
@krassowski krassowski changed the title All robot CI tests are failing, possibly due to a typo in notebook version specs All robot CI tests are failing, possibly due to a string in notebook version specs Dec 31, 2020
@krassowski
Copy link
Member Author

So it seems that we need to un-escape the JSON first as it comes from an HTML attribute.

@bollwyvl
Copy link
Collaborator

bollwyvl commented Dec 31, 2020 via email

@bollwyvl
Copy link
Collaborator

At box for a few... i'll try to toss something up....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants