Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] Fix robot PageConfig parsing, upgrading isort, pin jedi #445

Merged

Conversation

bollwyvl
Copy link
Collaborator

Sorry this kinda ended up as a mess (should have been a one-character PR, ha), but i had to rebuild my env, and some things were going a bit wacky. This has me running all the way to failing some acceptance tests for other reasons, but figured it was worth getting out, if only for cherry-picking the good parts.

References

Code changes

  • fix robot parsing of JSON which might contain single \ escapes
  • upgrade isort
  • pin jedi
  • get isort and and all the fixings from conda-forge only with nodefaults instead of defaults

User-facing changes

n/a

Backwards-incompatible changes

n/a

Chores

  • linted
  • tested
  • documented
  • changelog entry

@krassowski
Copy link
Member

Thank you!

@krassowski krassowski merged commit 69b3dfb into jupyter-lsp:master Dec 31, 2020
@bollwyvl
Copy link
Collaborator Author

bollwyvl commented Dec 31, 2020 via email

@krassowski
Copy link
Member

Hoping to do a final bugfix release for 2.2 today and start looking into 3.0 in the new year.

@bollwyvl bollwyvl mentioned this pull request Feb 2, 2021
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

All robot CI tests are failing, possibly due to a string in notebook version specs
2 participants