Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate ICompletionItems #239

Closed
wants to merge 2 commits into from

Conversation

edzkite
Copy link
Contributor

@edzkite edzkite commented Apr 4, 2020

References

LSP extension companion changes to jupyterlab/jupyterlab#7044

Dependent on jupyterlab/jupyterlab#8080

Code changes

  • Update LSP fetcher to use ICompletionItems
  • Transform Kernel reply into ICompletionItems
  • Update merge_replies to combine ICompletionItems

User-facing changes

  • JupyterLab will now render display text vs. insert text.
  • Previously:

Backwards-incompatible changes

None that I know of.

Chores

  • linted
  • tested
  • documented
  • changelog entry

@edzkite
Copy link
Contributor Author

edzkite commented Apr 9, 2020

@krassowski
Copy link
Member

krassowski commented Jul 26, 2020

@edzkite would you be interested in following up on this? I could push to this branch to change the target JupyterLab version to 2.2 so that the changes from your upstream PR that this one depends on will be there.

@edzkite
Copy link
Contributor Author

edzkite commented Jul 27, 2020

@krassowski We decided to fork the extension a couple of months ago to further customize its capabilities, and our changes' upstream compatibility is limited.

That said, please feel free to use this branch as a starting point for integrating with the new completions API if desired.

@krassowski krassowski mentioned this pull request Jul 29, 2020
4 tasks
@krassowski krassowski closed this Jul 29, 2020
@bollwyvl
Copy link
Collaborator

Bummer, man, sad to see you go. Good luck with your work, and thanks for this starting point!

@edzkite
Copy link
Contributor Author

edzkite commented Jul 29, 2020

Yeah of course! Best of luck to you guys as well, and looking forward to future opportunities for collaboration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants