Skip to content

Commit

Permalink
Increase kernel_info_reply poll loop by one (#923)
Browse files Browse the repository at this point in the history
Looks like the changes for jupyter/notebook#5908 introduced
an additional status response that pushed the actual 
kernel_info_reply out of the loop's range. 
Increasing it by one resolves the issue.
  • Loading branch information
kevin-bates authored Jan 9, 2021
1 parent 3f0bcf5 commit cde1937
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion enterprise_gateway/tests/test_handlers.py
Original file line number Diff line number Diff line change
Expand Up @@ -395,7 +395,7 @@ def test_kernel_comm(self):
}))

# Assert the reply comes back. Test will timeout if this hangs.
for _ in range(3):
for _ in range(4):
msg = yield ws.read_message()
msg = json_decode(msg)
if(msg['msg_type'] == 'kernel_info_reply'):
Expand Down
2 changes: 1 addition & 1 deletion requirements.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ dependencies:
- jinja2>=2.10
- jupyter_client>=6.1
- jupyter_core>=4.6.0
- notebook>=6.1.0,<6.1.6
- notebook>=6.1.0
- paramiko>=2.1.2
- pexpect>=4.2.0
- pip
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
'jupyter_client>=6.1',
'jupyter_core>=4.6.0',
'kubernetes>=4.0.0',
'notebook>=6.1.0,<6.1.6',
'notebook>=6.1.0',
'paramiko>=2.1.2',
'pexpect>=4.2.0',
'pycryptodomex>=3.9.7',
Expand Down

0 comments on commit cde1937

Please sign in to comment.