Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker_swarm.py #85

Merged
merged 1 commit into from
May 5, 2023
Merged

Update docker_swarm.py #85

merged 1 commit into from
May 5, 2023

Conversation

bsdz
Copy link
Contributor

@bsdz bsdz commented May 5, 2023

Updated to states to include "removing" to match statuses from docker docs and as suggest in Kevin's comment here.

Updated to states to include "removing".
@welcome
Copy link

welcome bot commented May 5, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@kevin-bates kevin-bates added the bug Something isn't working label May 5, 2023
Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @bsdz - thank you for applying this change to GP - it's much appreciated!

@kevin-bates
Copy link
Member

I've opened #86 to address the build failure - merging.

@kevin-bates kevin-bates merged commit 4b3de6a into jupyter-server:main May 5, 2023
@welcome
Copy link

welcome bot commented May 5, 2023

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants