Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip building js assets if they already exist #81

Merged
merged 3 commits into from
Dec 18, 2020
Merged

Skip building js assets if they already exist #81

merged 3 commits into from
Dec 18, 2020

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Dec 18, 2020 •
edited
Loading

Using skip_if_exists from jupyter_packaging.

This avoids rebuilding the assets if they already exist (for example in the source tarball).

Follow-up to the switch to jupyter-packaging from #69.

TODO

  • Check it behaves correctly when installing from the source tarball with pip install /path/to/sdist

@jtpio jtpio marked this pull request as draft December 18, 2020 12:39
@jtpio jtpio marked this pull request as ready for review December 18, 2020 15:19
@jtpio jtpio marked this pull request as draft December 18, 2020 15:28
@jtpio jtpio marked this pull request as ready for review December 18, 2020 20:17
@jtpio jtpio merged commit 1411cd6 into jupyter-server:master Dec 18, 2020
@jtpio jtpio deleted the skip-if-exists branch December 18, 2020 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jtpio