Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepend tag with Python package name if multiple packages are defined #570

Merged
merged 1 commit into from
Apr 20, 2024
Merged

Prepend tag with Python package name if multiple packages are defined #570

merged 1 commit into from
Apr 20, 2024

Conversation

krassowski
Copy link
Collaborator

This aims to alleviate #567 (comment) by checking for package-specific tags. As of today it effectively, skips the check for already existing tags when:

  • package names are defined for python packages, and
  • there is more than one python package

It does not implement creating tags per Python package yet.

@krassowski krassowski mentioned this pull request Apr 19, 2024
Closed
@blink1073 blink1073 added the bug Something isn't working label Apr 20, 2024
blink1073
blink1073 approved these changes Apr 20, 2024
View reviewed changes
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'll release this on Monday.

@blink1073 blink1073 merged commit 24ecdc0 into jupyter-server:main Apr 20, 2024
19 of 20 checks passed
@jtpio jtpio mentioned this pull request Apr 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blink1073 blink1073 blink1073 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krassowski @blink1073