Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jupyter_core pinning #1122

Merged
merged 2 commits into from
Dec 7, 2022

Conversation

ophie200
Copy link
Contributor

@ophie200 ophie200 commented Dec 7, 2022

Fixes #1121

@welcome
Copy link

welcome bot commented Dec 7, 2022

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@davidbrochart
Copy link
Contributor

Fixes #262.

Did you mean that it fixes #1121?

@codecov
Copy link

codecov bot commented Dec 7, 2022

Codecov Report

Base: 39.30% // Head: 79.96% // Increases project coverage by +40.65% 🎉

Coverage data is based on head (372c8d3) compared to base (487729c).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1122       +/-   ##
===========================================
+ Coverage   39.30%   79.96%   +40.65%     
===========================================
  Files          68       68               
  Lines        8021     8021               
  Branches     1584     1587        +3     
===========================================
+ Hits         3153     6414     +3261     
+ Misses       4673     1185     -3488     
- Partials      195      422      +227     
Impacted Files Coverage Δ
jupyter_server/_tz.py 100.00% <0.00%> (+5.88%) ⬆️
jupyter_server/auth/decorator.py 89.65% <0.00%> (+17.24%) ⬆️
jupyter_server/serverapp.py 80.15% <0.00%> (+17.28%) ⬆️
jupyter_server/services/security/handlers.py 100.00% <0.00%> (+17.64%) ⬆️
jupyter_server/extension/application.py 73.36% <0.00%> (+17.90%) ⬆️
jupyter_server/services/config/manager.py 100.00% <0.00%> (+18.75%) ⬆️
jupyter_server/extension/config.py 72.22% <0.00%> (+22.22%) ⬆️
jupyter_server/extension/manager.py 92.68% <0.00%> (+22.92%) ⬆️
jupyter_server/gateway/gateway_client.py 77.81% <0.00%> (+25.22%) ⬆️
jupyter_server/extension/handler.py 67.18% <0.00%> (+28.12%) ⬆️
... and 39 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@blink1073 blink1073 enabled auto-merge (squash) December 7, 2022 15:56
@blink1073 blink1073 merged commit a400c0e into jupyter-server:main Dec 7, 2022
@welcome
Copy link

welcome bot commented Dec 7, 2022

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid constraint (jupyter-core!=~5.0,>=4.12) found in jupyter-server-2.0.0 dependencies, skipping
3 participants