Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs and add new docs on ExtensionApp #116

Merged
merged 6 commits into from
Oct 10, 2019
Merged

Update docs and add new docs on ExtensionApp #116

merged 6 commits into from
Oct 10, 2019

Conversation

Zsailer
Copy link
Member

@Zsailer Zsailer commented Oct 9, 2019

This PR refactors Jupyter Server's documentation pages. Most of this PR is removing old notebook documentation. My goal is to slim down the documentation to focus only on Jupyter Server.

A major addition is that I've added a new page that explains the ExtensionApp merged in #48

@willingc
Copy link
Contributor

Thanks for removing the unrelated docs. Was just going to ask you about that @Zsailer

willingc
willingc approved these changes Oct 10, 2019
View reviewed changes
Copy link
Contributor

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @Zsailer. A few minor nits. I would go ahead and merge before the call tomorrow 👍

docs/source/frontends.rst Outdated Show resolved Hide resolved
docs/source/frontends.rst Outdated Show resolved Hide resolved
docs/source/frontends.rst Show resolved Hide resolved
docs/source/frontends.rst Outdated Show resolved Hide resolved
Zsailer and others added 3 commits October 9, 2019 18:39
@Zsailer
Copy link
Member Author

Zsailer commented Oct 10, 2019

Thanks, @willingc!

@Zsailer
Copy link
Member Author

Zsailer commented Oct 10, 2019

Merging for tomorrow's meeting per @willingc's request 😎

@Zsailer Zsailer merged commit c8f9e89 into jupyter-server:master Oct 10, 2019
@Zsailer Zsailer changed the title [WIP] Update docs and add new docs on ExtensionApp Update docs and add new docs on ExtensionApp Oct 10, 2019
@Zsailer
Copy link
Member Author

Zsailer commented Oct 10, 2019

I'll iterate on the docs more later.

@willingc
Copy link
Contributor

Huge improvement. Thanks @Zsailer!

@Zsailer Zsailer deleted the docs branch January 10, 2020 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willingc willingc willingc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zsailer @willingc