Register websocket handler from same module as kernel handlers #1249
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the 2.x refactor of kernel websocket management, the file from which the websocket handler is registered changed. The presents problems for applications that extend or leverage services and handlers from Jupyter Server (like Kernel Gateway and Enterprise Gateway, and perhaps other third-party applications). As a result, those applications must account for this this file which presents problems for supporting both JupyterServer 1.x and 2.x.
This change moves the websocket handler registration back to the
services/kernels/handlers.py
file so that "extending applications" don't require changes in their registration code to use JS 2.