Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference current_user to detect auth #1294

Merged
merged 1 commit into from
Jun 30, 2023

Conversation

bhperry
Copy link
Contributor

@bhperry bhperry commented Jun 29, 2023

Proposed fix for #1293

Use the newer format for checking authenticated user. _user_cache no longer exists, so api_last_activity is never being updated.

@welcome
Copy link

welcome bot commented Jun 29, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@bhperry bhperry force-pushed the bhperry/update_api_activity branch from db6b705 to b77be90 Compare June 29, 2023 20:06
@minrk minrk added the bug label Jun 30, 2023
@minrk minrk merged commit 8131c21 into jupyter-server:main Jun 30, 2023
@welcome
Copy link

welcome bot commented Jun 30, 2023

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@minrk
Copy link
Contributor

minrk commented Jun 30, 2023

Thanks!

@bhperry bhperry deleted the bhperry/update_api_activity branch June 30, 2023 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants