Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more informative error message when opening notebook and disk is full #1444

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add more informative error message when opening notebook and disk is full #1444

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
59c1960
Add more informative error message when disk is full
nmdanny Jul 24, 2024
ad184b8
Make error handling more robust to python configuration
nmdanny Jul 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions jupyter_server/base/handlers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
import mimetypes
import os
import re
import sqlite3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be a guard in case if Python build does no include sqlite3? There is one here:

jupyter_server/jupyter_server/services/sessions/sessionmanager.py

Lines 13 to 17 in f37967b

try:
import sqlite3
except ImportError:
# fallback on pysqlite2 if Python was build without sqlite
from pysqlite2 import dbapi2 as sqlite3 # type:ignore[no-redef]

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krassowski

Good catch, I also saw that these attributes were only introduced in python 3.11, so I've made this check a bit more robust, with a string based comparison as fallback

import types
import warnings
from http.client import responses
Expand Down Expand Up @@ -765,6 +766,12 @@ def write_error(self, status_code: int, **kwargs: Any) -> None:
if isinstance(e, HTTPError):
reply["message"] = e.log_message or message
reply["reason"] = e.reason
elif (
isinstance(e, sqlite3.OperationalError)
and e.sqlite_errorcode == sqlite3.SQLITE_FULL
):
reply["message"] = "Disk is full"
reply["reason"] = e.sqlite_errorname
else:
reply["message"] = "Unhandled error"
reply["reason"] = None
Expand Down
Loading