Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

basic approach for separate pytest plugin package #338

Closed

Conversation

bollwyvl
Copy link
Contributor

The simplest packaging I could do. Probably needs something to keep the parent/plugin versions in sync, and a release approach.

@kevin-bates
Copy link
Member

Thank you Nick! Given we're packaging the fixtures in https://github.com/jupyter-server/pytest-jupyter, I believe some of these changes are probably warranted there (e.g., use of options.entry_points). It would be great if you could take a look at the packaging aspects on that repo.

Others of these commits have been addressed in #335.

We were going to remove the entry point in a follow-on PR, post #335, which is #339, so I'm thinking the spirit of this PR is really what has happened in the pytest-jupyter repo and we should apply any additional necessities there.

Are you good with closing this PR, while focusing on #335 and #339 here, with some additional focus (relative to packaging, etc.) in pytest-juptyer?

@bollwyvl
Copy link
Contributor Author

bollwyvl commented Nov 13, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pytest_tornasync becomes hard dependency if pytest is installed
2 participants