Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update serverapp.py #367

Merged
merged 1 commit into from
Dec 25, 2020
Merged

Update serverapp.py #367

merged 1 commit into from
Dec 25, 2020

Conversation

michaelaye
Copy link
Contributor

fixing typo
fixes #366

fixing typo
@codecov-io
Copy link

codecov-io commented Dec 24, 2020

Codecov Report

Merging #367 (b82a5e0) into master (4e4ab20) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #367   +/-   ##
=======================================
  Coverage   69.29%   69.29%           
=======================================
  Files          56       56           
  Lines        6135     6135           
  Branches      804      804           
=======================================
  Hits         4251     4251           
  Misses       1616     1616           
  Partials      268      268           
Impacted Files Coverage Δ
jupyter_server/serverapp.py 61.26% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e4ab20...b82a5e0. Read the comment docs.

Copy link
Member

@Zsailer Zsailer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Zsailer Zsailer merged commit 1f5508e into jupyter-server:master Dec 25, 2020
Zsailer added a commit to Zsailer/jupyter_server that referenced this pull request Nov 18, 2022
…found. (jupyter-server#367)

* hydrate the synchronizer/session manager from metadata in notebooks on the filesystem

* drop redundant notebook.read call; add kernel_name to record
hMED22 pushed a commit to hMED22/jupyter_server that referenced this pull request Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo in cookie secret filename
3 participants