Delete the extra “or” that prevents easy cut-and-paste of URLs. #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this PR, the default output of server urls looks like:
Or copy and paste one of these URLs:
http://localhost:8888/?token=…
or http://127.0.0.1:8888/?token=…
This makes it easy to triple-click on the first line to copy and paste it into a browser. However, triple-clicking on the second line picks up the extra “or”, so you can’t just copy and paste it into the browser. Instead, you have to explicitly select each character by dragging your mouse, avoiding the “or”.
This change deletes the “or” so you can just triple-click on the second line to copy and paste the url.
|
I've wanted to make this PR for years and years, but it never was quite annoying enough any specific time to actually make the change... |
kevin-bates
approved these changes
Mar 26, 2021
hMED22
pushed a commit
to hMED22/jupyter_server
that referenced
this pull request
Jan 23, 2023
Delete the extra “or” that prevents easy cut-and-paste of URLs.
jonnygrout
added a commit
to jonnygrout/jupyter_server
that referenced
this pull request
Feb 2, 2023
This change was made in jupyter-server#460, but somehow it was not here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, the default output of server urls looks like:
This makes it easy to triple-click on the first line to copy and paste it into a browser. However, triple-clicking on the second line picks up the extra “or”, so you can’t just copy and paste it into the browser. Instead, you have to explicitly select each character by dragging your mouse, avoiding the “or”.
This change deletes the “or” so you can just triple-click on the second line to copy and paste the url.