Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct 'Content-Type' headers #471

Merged
merged 1 commit into from
Apr 9, 2021
Merged

Conversation

faucct
Copy link
Contributor

@faucct faucct commented Apr 9, 2021

@welcome
Copy link

welcome bot commented Apr 9, 2021

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@codecov-io
Copy link

codecov-io commented Apr 9, 2021

Codecov Report

Merging #471 (588b5be) into master (723786e) will increase coverage by 0.00%.
The diff coverage is 88.88%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #471   +/-   ##
=======================================
  Coverage   77.82%   77.82%           
=======================================
  Files         106      106           
  Lines        9127     9132    +5     
  Branches      976      979    +3     
=======================================
+ Hits         7103     7107    +4     
  Misses       1676     1676           
- Partials      348      349    +1     
Impacted Files Coverage Δ
jupyter_server/gateway/managers.py 76.87% <88.88%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 723786e...588b5be. Read the comment docs.

@blink1073 blink1073 added this to the 1.7 milestone Apr 9, 2021
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @faucct!

@blink1073 blink1073 merged commit 1f313d9 into jupyter-server:master Apr 9, 2021
@welcome
Copy link

welcome bot commented Apr 9, 2021

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@faucct faucct deleted the patch-1 branch April 9, 2021 08:35
hMED22 pushed a commit to hMED22/jupyter_server that referenced this pull request Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants