Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase minimum jupyter_core dependency #509

Merged
merged 1 commit into from
May 6, 2021

Conversation

kevin-bates
Copy link
Member

This bumps the minimum core dependency to 4.6.0 since that version of core is the first to include the is_hidden() method - on which the server relies. These dependencies had been inherited from Notebook and it defines is_hidden() locally so the previous core dependency (4.4.0) is still valid in that scenario.

Fixes #496

@codecov-commenter
Copy link

codecov-commenter commented May 6, 2021

Codecov Report

Merging #509 (1302c7e) into master (48cf6a5) will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #509      +/-   ##
==========================================
+ Coverage   77.08%   77.14%   +0.06%     
==========================================
  Files         107      107              
  Lines        9490     9490              
  Branches     1026     1026              
==========================================
+ Hits         7315     7321       +6     
+ Misses       1807     1803       -4     
+ Partials      368      366       -2     
Impacted Files Coverage Δ
jupyter_server/services/kernels/handlers.py 62.96% <0.00%> (+1.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48cf6a5...1302c7e. Read the comment docs.

Copy link
Member

@mwakaba2 mwakaba2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@blink1073 blink1073 added this to the 1.7 milestone May 6, 2021
@blink1073 blink1073 merged commit 69aa2e5 into jupyter-server:master May 6, 2021
hMED22 pushed a commit to hMED22/jupyter_server that referenced this pull request Jan 23, 2023
Increase minimum jupyter_core dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

is_hidden in jupyter_server==1.4.1 import breaks with jupyter_core==4.7.1
4 participants