Run pre_save_hook before model check #643
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
pre_save_hook
can potentially change the model, so checking for thetype
andcontent
should be done after the call to the hook.This will be needed in JupyterLab when we save documents from the back-end. In this case, the content won't be sent through the HTTP endpoint, but the hook will populate the model's content from the RTC server.
See jupyterlab/jupyterlab#11599.