Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update last_activity when pty_read #680

Closed
wants to merge 4 commits into from

Conversation

Wh1isper
Copy link
Contributor

see: jupyter/terminado#136

This PR implements the update of last_activity on read, making last_activity more accurate

@codecov-commenter
Copy link

codecov-commenter commented Jan 27, 2022

Codecov Report

Merging #680 (e5f139c) into main (745f5ba) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head e5f139c differs from pull request most recent head 35fa798. Consider uploading reports for the commit 35fa798 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #680   +/-   ##
=======================================
  Coverage   77.97%   77.98%           
=======================================
  Files         115      115           
  Lines       10817    10819    +2     
  Branches     1465     1465           
=======================================
+ Hits         8435     8437    +2     
  Misses       1981     1981           
  Partials      401      401           
Impacted Files Coverage Δ
jupyter_server/terminal/terminalmanager.py 89.02% <100.00%> (+0.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 745f5ba...35fa798. Read the comment docs.

@blink1073
Copy link
Contributor

I love the idea, but perhaps this should go in https://github.com/jupyter-server/jupyter_server_terminals since we're removing the terminals logic from this repo in #651

@Wh1isper
Copy link
Contributor Author

I love the idea, but perhaps this should go in https://github.com/jupyter-server/jupyter_server_terminals since we're removing the terminals logic from this repo in #651

Thanks, I created a PR in the new project

@Wh1isper
Copy link
Contributor Author

close as it merged in jupyter_server_terminals

@Wh1isper Wh1isper closed this Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants