Add Auto Pre-Commit #685
Merged
Add Auto Pre-Commit #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zsailer
approved these changes
Feb 2, 2022
|
Yeah, let's go for it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experimental support for running
pre-commiton a PR.With this configuration, any member, owner, or collaborator can comment
auto run pre-commit, and it will runpre-commitagainst the PR and push the change.For now, we use the
GITHUB_TOKENprovided to the workflow.The result is that the workflows are not automatically re-run for the commit: we have to close and re-open the PR.
We can later decide to use an access token from
@jupyterlab-bot, which would re-run the workflows.The end state is that we will ideally use jupyterlab-probot for this feature once it is available there.
This gives us a chance to kick the tires on the concept with minimal risk.