Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for Auto Pre-Commit #686

Closed
wants to merge 2 commits into from
Closed

Test for Auto Pre-Commit #686

wants to merge 2 commits into from

Conversation

blink1073
Copy link
Contributor

No description provided.

@blink1073
Copy link
Contributor Author

auto run pre-commit

@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2022

Running script "['pre-commit run --all-files']" on behalf of "blink1073"

@blink1073
Copy link
Contributor Author

auto run pre-commit

@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2022

Running script "['pre-commit run --all-files']" on behalf of "blink1073"

@blink1073
Copy link
Contributor Author

Hmm, it looks like it won't work at all without the access token. We can talk about it tomorrow at the dev meeting.

@blink1073
Copy link
Contributor Author

auto run pre-commit

@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2022

Running script "['pre-commit run --all-files']" on behalf of "blink1073"

by blink1073

["pre-commit run --all-files"]
@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2022

Codecov Report

Merging #686 (e7333ee) into main (8190db9) will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #686      +/-   ##
==========================================
+ Coverage   77.73%   77.80%   +0.06%     
==========================================
  Files         110      110              
  Lines       10465    10465              
  Branches     1405     1405              
==========================================
+ Hits         8135     8142       +7     
+ Misses       1933     1930       -3     
+ Partials      397      393       -4     
Impacted Files Coverage Δ
jupyter_server/serverapp.py 65.50% <0.00%> (+0.18%) ⬆️
...ter_server/tests/services/contents/test_manager.py 96.95% <0.00%> (+0.23%) ⬆️
jupyter_server/services/contents/filemanager.py 70.22% <0.00%> (+0.80%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8190db9...e7333ee. Read the comment docs.

@blink1073 blink1073 closed this Feb 3, 2022
@blink1073 blink1073 reopened this Feb 3, 2022
@blink1073
Copy link
Contributor Author

Aha! We needed an extra permission for contents: write

@blink1073
Copy link
Contributor Author

image

image

@blink1073 blink1073 closed this Feb 3, 2022
@blink1073 blink1073 deleted the blink1073-patch-1 branch January 15, 2023 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants