Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

serverapp: Use .absolute() instead of .resolve() for symlinks #712

Merged
merged 1 commit into from
Mar 9, 2022
Merged

serverapp: Use .absolute() instead of .resolve() for symlinks #712

merged 1 commit into from
Mar 9, 2022

Conversation

EricCousineau-TRI
Copy link
Contributor

Otherwise, this may hurt workflows like usage in Bazel runfile
symlink "forests"

Resolves #711

@EricCousineau-TRI
serverapp: Use .absolute() instead of .resolve() for symlinks
09d49d7 
Otherwise, this may hurt workflows like usage in Bazel runfile
symlink "forests"
@welcome
Copy link

welcome bot commented Mar 8, 2022

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@EricCousineau-TRI EricCousineau-TRI mentioned this pull request Mar 8, 2022
Closed
@Zsailer
Copy link
Member

Zsailer commented Mar 8, 2022

Thanks @EricCousineau-TRI!

Test failures appear to be unrelated.

@EricCousineau-TRI
Copy link
Contributor Author

Thank y'all! Any other actions required on my part for this to be merged, or waiting on add'l approvals?

@blink1073
Copy link
Contributor

Merging, thanks again @EricCousineau-TRI!

@blink1073 blink1073 merged commit 426a4c6 into jupyter-server:main Mar 9, 2022
@welcome
Copy link

welcome bot commented Mar 9, 2022

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@jess-x jess-x mentioned this pull request Mar 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidbrochart davidbrochart davidbrochart approved these changes

@Zsailer Zsailer Zsailer approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Usage of pathlib.Path.resolve() breaks symlink trees / forests
4 participants
@EricCousineau-TRI @Zsailer @blink1073 @davidbrochart