Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax type checking on ExtensionApp.serverapp #739

Merged
merged 1 commit into from
Mar 16, 2022

Conversation

minrk
Copy link
Contributor

@minrk minrk commented Mar 16, 2022

Some extensions (e.g. JupyterLab) apparently may be loaded hooked up to a legacy NotebookApp, which is not a ServerApp.

Hopefully my last fix trying to finish #730

Launching jupyter notebook with jupyterlab installed fails to load with:

    traitlets.traitlets.TraitError: The 'serverapp' trait of a LabApp instance expected a ServerApp, not the NotebookApp at '0x1035b51c0'.

Some extensions (e.g. JupyterLab) apparently may be loaded hooked up to a legacy NotebookApp, which is not a ServerApp.
@minrk minrk added the bug label Mar 16, 2022
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 changed the title relax type checking on ExtensionApp.serverapp Relax type checking on ExtensionApp.serverapp Mar 16, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 16, 2022

Codecov Report

Merging #739 (0c708f2) into main (a97edaa) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #739   +/-   ##
=======================================
  Coverage   70.64%   70.64%           
=======================================
  Files          62       62           
  Lines        7607     7607           
  Branches     1215     1215           
=======================================
  Hits         5374     5374           
  Misses       1865     1865           
  Partials      368      368           
Impacted Files Coverage Δ
jupyter_server/extension/application.py 73.47% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a97edaa...0c708f2. Read the comment docs.

@blink1073
Copy link
Contributor

Holy moly, we can now just re-run failed jobs only!

@blink1073 blink1073 merged commit 67f6140 into jupyter-server:main Mar 16, 2022
@minrk minrk deleted the any-serverapp branch March 16, 2022 12:00
@minrk
Copy link
Contributor Author

minrk commented Mar 16, 2022

Awesome! That was the very first feature request I +1'd when we switched to GHA.

@kathoef
Copy link

kathoef commented Mar 16, 2022

Wow, thank you a lot for fixing (and releasing) this so quickly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants