Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix contributing guide for building the docs #794

Merged
merged 2 commits into from
Apr 20, 2022

Conversation

andreyvelich
Copy link
Contributor

I fixed guide for building the docs:

  1. conda env has been changed to jupyter_server_docs
  2. We have to use jupyter_server in our doc requirements.
  3. I regenerated docs using make html.

cc @Zsailer

@blink1073
Copy link
Contributor

I think the full_config.rst file needs to be added to gitignore, since it is generated on demand.

@andreyvelich
Copy link
Contributor Author

I think the full_config.rst file needs to be added to gitignore, since it is generated on demand.

That makes sense @blink1073.
We are generating this config as part of conf.py.

@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2022

Codecov Report

Merging #794 (0e91104) into main (6740cb5) will decrease coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #794      +/-   ##
==========================================
- Coverage   69.99%   69.89%   -0.10%     
==========================================
  Files          62       62              
  Lines        7368     7368              
  Branches     1223     1223              
==========================================
- Hits         5157     5150       -7     
- Misses       1839     1845       +6     
- Partials      372      373       +1     
Impacted Files Coverage Δ
jupyter_server/services/kernels/handlers.py 57.44% <0.00%> (-1.07%) ⬇️
jupyter_server/services/kernels/kernelmanager.py 79.66% <0.00%> (-0.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6740cb5...0e91104. Read the comment docs.

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit ef1deca into jupyter-server:main Apr 20, 2022
@andreyvelich andreyvelich deleted the fix-doc-build branch April 20, 2022 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants