Enable GatewayClient managers to be configurable #834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #834 +/- ##
==========================================
+ Coverage 70.05% 70.10% +0.04%
==========================================
Files 63 63
Lines 7548 7559 +11
Branches 1258 1260 +2
==========================================
+ Hits 5288 5299 +11
Misses 1880 1880
Partials 380 380
Continue to review full report at Codecov.
|
|
This is ready for review. I think we should backport this PR once merged. |
kevin-bates
approved these changes
May 6, 2022
|
@meeseeksdev please backport to 1.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/jupyter_server
that referenced
this pull request
May 6, 2022
Zsailer
added a commit
that referenced
this pull request
May 6, 2022
) Co-authored-by: Zachary Sailer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If GatewayClient is enabled, it hardcodes the session_manager, kernel_manager, and kernelspec_manager. I think we still want these classes to be overridable. This PR keeps the defaults the same (backwards compatible) while also allowing it to be configurable.