Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test python 3.11 on ubuntu #839

Merged
merged 10 commits into from
Sep 15, 2022
Merged

Conversation

blink1073
Copy link
Contributor

@blink1073 blink1073 commented May 9, 2022

Start testing the RC release of Python 3.11

@codecov-commenter
Copy link

codecov-commenter commented May 9, 2022

Codecov Report

Base: 72.51% // Head: 72.40% // Decreases project coverage by -0.10% ⚠️

Coverage data is based on head (955551a) compared to base (7d2154a).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #839      +/-   ##
==========================================
- Coverage   72.51%   72.40%   -0.11%     
==========================================
  Files          64       64              
  Lines        8197     8197              
  Branches     1373     1373              
==========================================
- Hits         5944     5935       -9     
- Misses       1840     1846       +6     
- Partials      413      416       +3     
Impacted Files Coverage Δ
jupyter_server/services/contents/filemanager.py 70.05% <0.00%> (-1.57%) ⬇️
jupyter_server/serverapp.py 65.67% <0.00%> (-0.10%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@blink1073
Copy link
Contributor Author

Nope, looks like we're blocked on pyzmq building on Python 3.11.:

             gcc -pthread -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -fPIC -DHAVE_SYS_UN_H=1 -Ibundled/zeromq/include -Izmq/utils -I/opt/hostedtoolcache/Python/3.11.0-beta.1/x64/include/python3.11 -c zmq/backend/cython/_device.c -o build/temp.linux-x86_64-cpython-311/zmq/backend/cython/_device.o
            zmq/backend/cython/_device.c:217:12: fatal error: longintrepr.h: No such file or directory
              217 |   #include "longintrepr.h"
                  |            ^~~~~~~~~~~~~~~
            compilation terminated.
            error: command '/usr/bin/gcc' failed with exit code 1
            [end of output]

@blink1073
Copy link
Contributor Author

I opened zeromq/pyzmq#1697

@blink1073 blink1073 marked this pull request as draft May 9, 2022 10:41
@blink1073
Copy link
Contributor Author

Wow, that is annoying:

+ pip install --no-deps -v .
Using pip 22.0.4 from /opt/hostedtoolcache/Python/3.11.0-beta.1/x64/lib/python3.11/site-packages/pip (python 3.11)
Processing /home/runner/work/jupyter_server/jupyter_server
  Installing build dependencies: started
  Running command pip subprocess to install build dependencies
  Collecting flit_core<4,>=3.2
    Downloading flit_core-3.7.1-py3-none-any.whl (60 kB)
       ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 60.2/60.2 KB 3.2 MB/s eta 0:00:00
  Installing collected packages: flit_core
  Successfully installed flit_core-3.7.1
  Installing build dependencies: finished with status 'done'
  Getting requirements to build wheel: started
  Running command Getting requirements to build wheel
  Getting requirements to build wheel: finished with status 'done'
  Installing backend dependencies: started
  Running command pip subprocess to install backend dependencies

What even does no-deps mean?

@davidbrochart
Copy link
Contributor

What even does no-deps mean?

You mean --no-deps has no effect on Python 3.11?

@blink1073
Copy link
Contributor Author

Hmm, let's test that theory...

@blink1073
Copy link
Contributor Author

Same thing with Python 3.10. Let me try editable mode again.

@blink1073
Copy link
Contributor Author

Next try is building the sdist first and then installing from that with --pre.

@blink1073
Copy link
Contributor Author

Okay, this seems like a bug in flit or pip. I don't see why we should be picking up run time dependencies when building a wheel or sdist.

@blink1073
Copy link
Contributor Author

It isn't a pip bug, because it happens with both pip and build. I think this is related to pypa/flit#354

@blink1073
Copy link
Contributor Author

Cool, so the solution is not to use dynamic versions with flit, since doing so pulls in the runtime requirements. However, now we're stuck on PyYAML:

         File "/tmp/pip-build-env-93f8_jkm/overlay/lib/python3.11/site-packages/setuptools/_distutils/command/sdist.py", line 312, in _add_defaults_ext
          self.filelist.extend(build_ext.get_source_files())
                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "setup.py", line 204, in get_source_files
          self.cython_sources(ext.sources, ext)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "/tmp/pip-build-env-93f8_jkm/overlay/lib/python3.11/site-packages/setuptools/_distutils/cmd.py", line 103, in __getattr__
          raise AttributeError(attr)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^
      AttributeError: cython_sources
      [end of output]

@blink1073
Copy link
Contributor Author

Blocked on yaml/pyyaml#630

@blink1073 blink1073 marked this pull request as ready for review September 15, 2022 15:43
@blink1073 blink1073 changed the title Try python 3.11 on ubuntu Test python 3.11 on ubuntu Sep 15, 2022
@blink1073 blink1073 merged commit a99119e into jupyter-server:main Sep 15, 2022
@blink1073 blink1073 deleted the try-python-311 branch September 15, 2022 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants