Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make start_kernel env extend os.environ #859

Merged
merged 2 commits into from
May 27, 2022
Merged

Make start_kernel env extend os.environ #859

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
afb37cf
Make start_kernel env extend os.environ
vidartf May 27, 2022
79a9e12
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] May 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion jupyter_server/services/sessions/sessionmanager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
"""A base class session manager."""
# Copyright (c) Jupyter Development Team.
# Distributed under the terms of the Modified BSD License.
import os
import pathlib
import uuid

Expand Down Expand Up @@ -274,7 +275,7 @@ async def start_kernel_for_session(self, session_id, path, name, type, kernel_na
kernel_id = await self.kernel_manager.start_kernel(
path=kernel_path,
kernel_name=kernel_name,
env={"JPY_SESSION_NAME": path},
env={**os.environ, "JPY_SESSION_NAME": path},
)
return kernel_id

Expand Down