Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow new file types #895

Merged

Conversation

davidbrochart
Copy link
Contributor

In #884 we talked about the possibility to register new file types. It could be needed in the future, and maybe a notebook file type should be such a registered type (through a jupyter-server extension).
But for now an easier path would be to not throw an error when we get an unknown file type, and treat it as a generic file.

Closes jupyterlab/jupyterlab#12719.

@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2022

Codecov Report

Merging #895 (a22e015) into main (3090893) will increase coverage by 0.03%.
The diff coverage is 0.00%.

❗ Current head a22e015 differs from pull request most recent head ca14046. Consider uploading reports for the commit ca14046 to get more accurate results

@@            Coverage Diff             @@
##             main     #895      +/-   ##
==========================================
+ Coverage   72.24%   72.28%   +0.03%     
==========================================
  Files          65       65              
  Lines        7983     7980       -3     
  Branches     1334     1333       -1     
==========================================
+ Hits         5767     5768       +1     
+ Misses       1810     1805       -5     
- Partials      406      407       +1     
Impacted Files Coverage Δ
jupyter_server/services/contents/handlers.py 85.63% <0.00%> (-0.93%) ⬇️
jupyter_server/extension/manager.py 92.75% <0.00%> (+0.07%) ⬆️
jupyter_server/services/contents/filemanager.py 72.20% <0.00%> (+0.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3090893...ca14046. Read the comment docs.

Zsailer
Zsailer previously approved these changes Jul 6, 2022
@trungleduc
Copy link

Thanks @davidbrochart and @Zsailer for working on it. Is there anything I can help to get it in? We depend on this fix for a downstream use case.

@davidbrochart
Copy link
Contributor Author

I think it's ready to be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants