-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow new file types #895
Allow new file types #895
Conversation
Codecov Report
@@ Coverage Diff @@
## main #895 +/- ##
==========================================
+ Coverage 72.24% 72.28% +0.03%
==========================================
Files 65 65
Lines 7983 7980 -3
Branches 1334 1333 -1
==========================================
+ Hits 5767 5768 +1
+ Misses 1810 1805 -5
- Partials 406 407 +1
Continue to review full report at Codecov.
|
ea741fc
to
0e509bb
Compare
0e509bb
to
94901e7
Compare
Thanks @davidbrochart and @Zsailer for working on it. Is there anything I can help to get it in? We depend on this fix for a downstream use case. |
I think it's ready to be merged. |
a22e015
to
ca14046
Compare
In #884 we talked about the possibility to register new file types. It could be needed in the future, and maybe a
notebook
file type should be such a registered type (through a jupyter-server extension).But for now an easier path would be to not throw an error when we get an unknown file type, and treat it as a generic
file
.Closes jupyterlab/jupyterlab#12719.